Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: benchmark CLI tool #904

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

niermann999
Copy link
Contributor

@niermann999 niermann999 commented Dec 10, 2024

Call the benchmark tools from commandline using the detector reader and configure them using io options. In order to be able to configure the benchmarks the same way as the inbuilt benchmarks which are run for the continuous benchmark monitoring, new options for the random seed and track momentum ranges were added to the track generator options parsing.

Also adds a few small changes and fixes, eg:

  • pass data to benchmark functors as const pointers
  • set the random seed to default in the inbuilt benchmarks (this will make comparisons with the CLI tools easier, since this is the default option)
  • explicitely set warmup to true for inbuilt benchmarks
  • build the CUDA benchmark library for each algebra plugin individually to set up the template instantiations correcly

This PR will make benchmarking the ODD and ITk possible

@niermann999 niermann999 force-pushed the feat-benchmark-tool branch 2 times, most recently from 4558c20 to e4423f1 Compare December 18, 2024 19:42
@niermann999 niermann999 added enhancement New feature or request priority: high high priority blocked This item is blocked by another item labels Dec 20, 2024
@niermann999 niermann999 force-pushed the feat-benchmark-tool branch 3 times, most recently from 3c71893 to c9ca8c3 Compare January 2, 2025 14:35
@niermann999 niermann999 marked this pull request as ready for review January 8, 2025 13:16
@niermann999 niermann999 removed the blocked This item is blocked by another item label Jan 8, 2025
@niermann999 niermann999 force-pushed the feat-benchmark-tool branch 8 times, most recently from d3b6d27 to 5285eaf Compare January 8, 2025 16:47
Copy link

sonarqubecloud bot commented Jan 8, 2025

@niermann999 niermann999 requested review from stephenswat, beomki-yeo and asalzburger and removed request for stephenswat January 8, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority: high high priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant